Skip to content

Testing Beta URL by adding environment var in tox#55

Merged
nabobalis merged 10 commits into
Helioviewer-Project:mainfrom
akash5100:config
Aug 13, 2022
Merged

Testing Beta URL by adding environment var in tox#55
nabobalis merged 10 commits into
Helioviewer-Project:mainfrom
akash5100:config

Conversation

@akash5100

@akash5100 akash5100 commented Aug 9, 2022 •
edited by nabobalis
Loading

Copy link
Copy Markdown
Collaborator

Fixes #52

@akash5100 akash5100 requested a review from nabobalis August 9, 2022 06:49
@akash5100 akash5100 self-assigned this Aug 9, 2022
@codecov-commenter

codecov-commenter commented Aug 9, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #55 (f7e6f4c) into main (ce5ec27) will decrease coverage by 0.95%.
The diff coverage is 89.65%.

@@             Coverage Diff             @@
##              main      #55      +/-   ##
===========================================
- Coverage   100.00%   99.04%   -0.96%     
===========================================
  Files           16       18       +2     
  Lines          285      314      +29     
===========================================
+ Hits           285      311      +26     
- Misses           0        3       +3
Impacted Files Coverage Δ
hvpy/facade.py 96.29% <75.00%> (-3.71%) ⬇️
hvpy/api_groups/movies/re_queue_movie.py 85.71% <85.71%> (ø)
hvpy/api_groups/movies/get_movie_status.py 100.00% <100.00%> (ø)
hvpy/parameters.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

akash5100
akash5100 commented Aug 9, 2022
View reviewed changes
Comment thread hvpy/api_groups/jpeg2000/tests/test_get_jp2_header.py Outdated
akash5100
akash5100 commented Aug 9, 2022
View reviewed changes
Comment thread hvpy/api_groups/jpeg2000/tests/test_get_jp2_header.py
akash5100
akash5100 commented Aug 9, 2022
View reviewed changes
Comment thread hvpy/api_groups/jpeg2000/tests/test_get_jpx.py Outdated
akash5100
akash5100 commented Aug 9, 2022
View reviewed changes
Comment thread hvpy/api_groups/movies/tests/test_get_movie_status.py
nabobalis
nabobalis reviewed Aug 9, 2022
View reviewed changes
Comment thread hvpy/api_groups/jpeg2000/tests/test_get_jpx_closest_to_mid_point.py Outdated
Comment thread hvpy/api_groups/jpeg2000/tests/test_get_jp2_header.py Outdated
nabobalis
nabobalis reviewed Aug 10, 2022
View reviewed changes
Comment thread docs/dev_guide.rst Outdated
nabobalis
nabobalis reviewed Aug 10, 2022
View reviewed changes
Comment thread hvpy/api_groups/jpeg2000/tests/test_get_jpx.py Outdated
nabobalis
nabobalis reviewed Aug 10, 2022
View reviewed changes
Comment thread hvpy/api_groups/jpeg2000/tests/test_get_jpx.py Outdated
@nabobalis nabobalis changed the title Testing Beta URL by adding environment var in TOX Testing Beta URL by adding environment var in tox Aug 10, 2022
nabobalis
nabobalis reviewed Aug 10, 2022
View reviewed changes
Comment thread docs/dev_guide.rst Outdated
@nabobalis nabobalis merged commit c99b633 into Helioviewer-Project:main Aug 13, 2022
@akash5100 akash5100 deleted the config branch August 14, 2022 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@nabobalis nabobalis nabobalis approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@akash5100 akash5100

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change BASE_URL to beta server for tests

3 participants

@akash5100 @codecov-commenter @nabobalis